Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(git-node): auto-fetch comparison branch when preparing release #846

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 27, 2024

A few things in the release preparation script were still relying on the local clone to be up-to-date (e.g. to get the Current line (to prepare a LTS release), it relied on the release tag to be present, or when comparing branches). Given preparing a release requires internet access anyway, it seems easy enough to rely on it rather than the local clone.

Testing it from a codespace like this:

git clone https://github.com/nodejs/node.git --single-branch --branch=v20.x-staging --no-tags
cd node
../bin/git-node.js release --prepare

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you tried it locally.

@aduh95 aduh95 merged commit a8529ed into nodejs:main Aug 28, 2024
9 checks passed
@aduh95 aduh95 deleted the auto-fetch-release-tag branch August 28, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants